netdev - Re: [PATCH net-next 03/15] net/mlx5: HWS, denote how refcounts are protected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250106163624.7cebcbeb@kernel.org>
Date: Mon, 6 Jan 2025 16:36:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, <netdev@...r.kernel.org>, Saeed Mahameed
 <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Leon Romanovsky
 <leonro@...dia.com>, Mark Bloch <mbloch@...dia.com>, Moshe Shemesh
 <moshe@...dia.com>, Yevgeny Kliteynik <kliteyn@...dia.com>, Vlad Dogaru
 <vdogaru@...dia.com>, Erez Shitrit <erezsh@...dia.com>
Subject: Re: [PATCH net-next 03/15] net/mlx5: HWS, denote how refcounts are
 protected

On Thu, 2 Jan 2025 20:14:02 +0200 Tariq Toukan wrote:
> From: Yevgeny Kliteynik <kliteyn@...dia.com>
> 
> Some HWS structs have refcounts that are just u32.
> Comment how they are protected and add '__must_hold()'
> annotation where applicable.

Out of curiosity -- do you have tooling which uses those annotations?
Can smatch use it? IIUC the sparse matching on the lock state is pretty
much disabled these days.