netdev - Re: [PATCH v1 net 2/3] gtp: Destroy device along with udp socket's netns dismantle.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABAhCOR7Y058pDUKBOQ6vDeEZkHYQqeyg97nrBYoJHqkFgDd7w@mail.gmail.com>
Date: Wed, 8 Jan 2025 16:55:16 +0800
From: Xiao Liang <shaw.leon@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	Pablo Neira Ayuso <pablo@...filter.org>, Harald Welte <laforge@...monks.org>
Subject: Re: [PATCH v1 net 2/3] gtp: Destroy device along with udp socket's
 netns dismantle.

On Wed, Jan 8, 2025 at 2:29 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
[...]
> @@ -2480,6 +2480,11 @@ static void __net_exit gtp_net_exit_batch_rtnl(struct list_head *net_list,
>         list_for_each_entry(net, net_list, exit_list) {
>                 struct gtp_net *gn = net_generic(net, gtp_net_id);
>                 struct gtp_dev *gtp, *gtp_next;
> +               struct net_device *dev;
> +
> +               for_each_netdev(net, dev)
> +                       if (dev->rtnl_link_ops == &gtp_link_ops)
> +                               gtp_dellink(dev, dev_to_kill);

I'm not sure, but do we usually have to clean up devices
in the netns being deleted? Seems default_device_ops
can handle it.

>
>                 list_for_each_entry_safe(gtp, gtp_next, &gn->gtp_dev_list, list)
>                         gtp_dellink(gtp->dev, dev_to_kill);
> --
> 2.39.5 (Apple Git-154)
>