netdev - Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108094436.GF2772@kernel.org>
Date: Wed, 8 Jan 2025 09:44:36 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from
 hsr_add_port()

On Tue, Jan 07, 2025 at 02:47:01PM +0000, Eric Dumazet wrote:
> A synchronize_rcu() was added by mistake in commit
> c5a759117210 ("net/hsr: Use list_head (and rcu) instead
> of array for slave devices.")
> 
> RCU does not mandate to observe a grace period after
> list_add_tail_rcu().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>