netdev - Re: [PATCH net]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250108102140.GI2772@kernel.org>
Date: Wed, 8 Jan 2025 10:21:40 +0000
From: Simon Horman <horms@...nel.org>
To: Sudheer Kumar Doredla <s-doredla@...com>
Cc: s-vadapalli@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, gnault@...hat.com, linux-omap@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	t-patil@...com, j-keerthy@...com
Subject: Re: [PATCH net]

On Wed, Jan 08, 2025 at 01:43:03PM +0530, Sudheer Kumar Doredla wrote:
> cpsw_ale_get_field was returning incorrect data when requesting higher
> word fields. Additionally, cpsw_ale_set_field was writing incorrect 
> data into the ALE entry while updating.
> 
> For example, while reading word2, word3 fields (62 to 64 bits), the word3
> data was shifted to an incorrect position after reading. The same issue
> occurred when setting an ALE entry.
> 
> This patch fixes the shifting of the word3 data by aligning it with the
> required fileds, ensuring the correct value is returned from
> cpsw_ale_get_field, even for higher words.
> It also ensures the correct vlaue is written into ALE entry using
> cpsw_ale_set_field.

Hi Sudheer,

It would be interesting to include some information on how this problem
manifests in practice.

And, as a fix for net this should have a fixes tag.
(Immediately above the other tags, no blank line in between.)

Perhaps this one is appropriate?

Fixes: b685f1a58956 ("net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()/cpsw_ale_set_field()")

> Signed-off-by: Sudheer Kumar Doredla <s-doredla@...com>

And, lastly, the subject for this patch seems to be missing.
Please add one:

	Subject: [PATCH v2 net] net: ethernet: ti: cpsw_ale: ...

The code changes themselves look good to me.
So with the above addressed, feel free to include.

Reviewed-by: Simon Horman <horms@...nel.org>

...

-- 
pw-bot: changes-requested