netdev - Re: [PATCH net-next 11/14] net: pse-pd: Add support for PSE device index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108094201.63463180@kernel.org>
Date: Wed, 8 Jan 2025 09:42:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Kory Maincent <kory.maincent@...tlin.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>,
 Jonathan Corbet <corbet@....net>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org, Kyle Swenson
 <kyle.swenson@....tech>, Dent Project <dentproject@...uxfoundation.org>,
 kernel@...gutronix.de, Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 11/14] net: pse-pd: Add support for PSE device
 index

On Wed, 8 Jan 2025 06:47:10 +0100 Oleksij Rempel wrote:
> On Tue, Jan 07, 2025 at 05:18:34PM -0800, Jakub Kicinski wrote:
> > On Sat, 04 Jan 2025 23:27:36 +0100 Kory Maincent wrote:  
> > > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > > 
> > > Add support for a PSE device index to report the PSE controller index to
> > > the user through ethtool. This will be useful for future support of power
> > > domains and port priority management.  
> > 
> > Can you say more? How do the PSE controllers relate to netdevs?
> > ethtool is primarily driven by netdev / ifindex.
> > If you're starting to build your own object hierarchy you may be
> > better off with a separate genl family.  
>             
> I hope this schema may help to explain the topology:
> 
> 	                              +--- netdev / ifindex 0
> 	    +--- PSE power domain 0 --+--- netdev / ifindex 1
>             |                         +--- netdev / ifindex 2
> PSE ctrl 0 -+
>             |                         +--- netdev / ifindex 3
>             +--- PSE power domain 1 --+--- netdev / ifindex 4
> 	                              +--- netdev / ifindex 5
> 
> 	                              +--- netdev / ifindex 6
> 	    +--- PSE power domain 2 --+--- netdev / ifindex 7
>             |                         +--- netdev / ifindex 8
> PSE ctrl 1 -+
>             |                         +--- netdev / ifindex 9
>             +--- PSE power domain 3 --+--- netdev / ifindex 10
> 	                              +--- netdev / ifindex 11
> 
> PSE device index is needed to find actually PSE controller related to
> specific netdev / ifindex.

Makes sense. So how does it end up looking in terms of APIs 
and attributes? Will we need much more than power limits at
the domain and ctrl level?