netdev - Re: [PATCH] net: ethernet: sunplus: Switch to ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108100905.799e6112@kernel.org>
Date: Wed, 8 Jan 2025 10:09:05 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yeking@...54.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 wellslutw@...il.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH] net: ethernet: sunplus: Switch to ndo_eth_ioctl

On Wed,  8 Jan 2025 14:12:38 +0000 Yeking@...54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
> 
> ndo_do_ioctl is no longer called by the device ioctl handler,
> so use ndo_eth_ioctl instead.

I presume this used to work and now it doesn't?
If so a Fixes tag pointing to the commit that broke it would 
be in order.

Please also mention how you tested this. Is this something you actually
run into on real HW? Or just found by code inspection and only compile
tested?
-- 
pw-bot: cr