netdev - Re: [PATCH][Resend][net-next] net: ethtool: Use hwprov under rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250107174045.3763ffd2@kernel.org>
Date: Tue, 7 Jan 2025 17:40:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Li RongQing <lirongqing@...du.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH][Resend][net-next] net: ethtool: Use hwprov under
 rcu_read_lock

On Tue, 7 Jan 2025 17:39:43 -0800 Jakub Kicinski wrote:
> On Sun,  5 Jan 2025 16:40:52 +0800 Li RongQing wrote:
> > hwprov should be protected by rcu_read_lock to prevent possible UAF
> > 
> > Fixes: 4c61d809cf60 ("net: ethtool: Fix suspicious rcu_dereference usage")
> > Signed-off-by: Li RongQing <lirongqing@...du.com>  
> 
> In the future please make sure you CC the appropriate authors and
> maintainers. Always use get_maintainer.pl on the generated patch file.

Actually, the code could be improved, too.

Don't declare ret, move the declaration of int err instead.
-- 
pw-bot: cr