netdev - Re: [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108134433.2e3978fd@kernel.org>
Date: Wed, 8 Jan 2025 13:44:33 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Paul Fertser <fercerpav@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, Potin Lai
 <potin.lai@...ntatw.com>, Potin Lai <potin.lai.pt@...il.com>,
 sam@...dozajonas.com, fr0st61te@...il.com
Subject: Re: [PATCH net v2] Revert "net/ncsi: change from
 ndo_set_mac_address to dev_set_mac_address"

On Wed, 8 Jan 2025 23:23:23 +0300 Paul Fertser wrote:
> > Original posting by Potin Lai:
> >   https://lore.kernel.org/20241129-potin-revert-ncsi-set-mac-addr-v1-1-94ea2cb596af@gmail.com  
> 
> Unfortunately I wasn't on CC and missed that. Can we fix this proper
> way please, do we have few more days?

Sure thing, we need it in the tree early next week, so probably on
the list by Friday so that folks have a chance to review.

> If I get it right dev_set_mac_address() just isn't meant to be ever
> called from a softirq (and NCSI here is special in getting a MAC
> address update from a "network" frame so that happens in
> net_rx_action() context). So postponing the actual processing of this
> reply looks like the way to go, right?

I think so. Only trickiness I can think of is the ordering of the work
vs admin setting the address from user space. Do venture a patch,
I don't know enough about NC-SI.. :(