netdev - RE: [EXTERNAL] [PATCH net-next v03 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250108055144.3556942-1-gur.stavi@huawei.com>
Date: Wed, 8 Jan 2025 07:51:44 +0200
From: Gur Stavi <gur.stavi@...wei.com>
To: <sumang@...vell.com>
CC: <andrew+netdev@...n.ch>, <cai.huoqing@...ux.dev>, <corbet@....net>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
	<guoxin09@...wei.com>, <gur.stavi@...wei.com>, <helgaas@...nel.org>,
	<horms@...nel.org>, <kuba@...nel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <meny.yossefi@...wei.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <shenchenyang1@...ilicon.com>,
	<shijing34@...wei.com>, <wulike1@...wei.com>, <zhoushuai28@...wei.com>
Subject: RE: [EXTERNAL] [PATCH net-next v03 1/1] hinic3: module initialization and tx/rx logic

> >+static void hinic3_link_status_change(struct net_device *netdev, bool
> >link_status_up)
> >+{
> >+	struct hinic3_nic_dev *nic_dev =3D netdev_priv(netdev);
> >+
> >+	if (!HINIC3_CHANNEL_RES_VALID(nic_dev))
> >+		return;
> >+
> >+	if (link_status_up) {
> >+		if (netif_carrier_ok(netdev))
> >+			return;
> >+
> >+		nic_dev->link_status_up =3D true;
> >+		netif_carrier_on(netdev);

> [Suman] don't we need to call netif_tx_start_all_queues as well?=20

No, netif_tx_start/stop_all_queues should be called in ndo_open/close.
Carrier status change event does not start/stop tx queues.

> >+		netdev_dbg(netdev, "Link is up\n");
> >+	} else {
> >+		if (!netif_carrier_ok(netdev))
> >+			return;
> >+
> >+		nic_dev->link_status_up =3D false;
> >+		netif_carrier_off(netdev);

> [Suman] don't we need to call netif_tx_stop_all_queues as well?

Same.

> >+		netdev_dbg(netdev, "Link is down\n");
> >+	}
> >+}
> >+