netdev - Re: [PATCH nf-next] netfilter: br_netfilter: remove unused conditional and dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250109151818.GH7706@kernel.org>
Date: Thu, 9 Jan 2025 15:18:18 +0000
From: Simon Horman <horms@...nel.org>
To: Antoine Tenart <atenart@...nel.org>
Cc: pablo@...filter.org, kadlec@...filter.org, dsahern@...nel.org,
	menglong8.dong@...il.com, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH nf-next] netfilter: br_netfilter: remove unused
 conditional and dead code

On Thu, Jan 09, 2025 at 10:37:09AM +0100, Antoine Tenart wrote:
> The SKB_DROP_REASON_IP_INADDRERRORS drop reason is never returned from
> any function, as such it cannot be returned from the ip_route_input call
> tree. The 'reason != SKB_DROP_REASON_IP_INADDRERRORS' conditional is
> thus always true.
> 
> Looking back at history, commit 50038bf38e65 ("net: ip: make
> ip_route_input() return drop reasons") changed the ip_route_input
> returned value check in br_nf_pre_routing_finish from -EHOSTUNREACH to
> SKB_DROP_REASON_IP_INADDRERRORS. It turns out -EHOSTUNREACH could not be
> returned either from the ip_route_input call tree and this since commit
> 251da4130115 ("ipv4: Cache ip_error() routes even when not
> forwarding.").
> 
> Not a fix as this won't change the behavior. While at it use
> kfree_skb_reason.
> 
> Signed-off-by: Antoine Tenart <atenart@...nel.org>
> ---
>  net/bridge/br_netfilter_hooks.c | 30 +-----------------------------
>  1 file changed, 1 insertion(+), 29 deletions(-)

Nice diffstat :)

Reviewed-by: Simon Horman <horms@...nel.org>