netdev - Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05c8648c-d6ca-419b-a4ec-6b305f4ca19f@rbox.co>
Date: Thu, 9 Jan 2025 16:27:51 +0100
From: Michal Luczaj <mhal@...x.co>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
 Stefan Hajnoczi <stefanha@...hat.com>, linux-kernel@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Wongi Lee <qwerty@...ori.io>, "David S. Miller" <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Bobby Eshleman <bobby.eshleman@...edance.com>,
 virtualization@...ts.linux.dev, Eugenio Pérez
 <eperezma@...hat.com>, Luigi Leonardi <leonardi@...hat.com>,
 bpf@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
 "Michael S. Tsirkin" <mst@...hat.com>, Hyunwoo Kim <v4bel@...ori.io>,
 kvm@...r.kernel.org
Subject: Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport
 changes

On 1/9/25 14:42, Stefano Garzarella wrote:
> On Thu, Jan 09, 2025 at 02:34:28PM +0100, Michal Luczaj wrote:
>> ...
>> That said, when I apply this patch, but drop the `sk->sk_state !=
>> TCP_LISTEN &&`: no more splats.
> 
> We can't drop `sk->sk_state != TCP_LISTEN &&` because listener socket 
> doesn't have any transport (vsk->transport == NULL), so every connection 
> request will receive an error, so maybe this is the reason of no splats.

Bah, sorry, I didn't run the test suit.

> I'm cooking some more patches to fix Hyunwoo's scenario handling better 
> the close work when the virtio destructor is called.
> 
> I'll run your reproduces to test it, thanks for that!
> 
> Stefano
>