netdev - Re: [PATCH] lockd: add netlink control interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250109083604.77ffe61d@kernel.org>
Date: Thu, 9 Jan 2025 08:36:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jeff Layton <jlayton@...nel.org>
Cc: Donald Hunter <donald.hunter@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Chuck Lever
 <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>, Olga Kornievskaia
 <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
 <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>, Anna Schumaker
 <anna@...nel.org>, Scott Mayhew <smayhew@...hat.com>, Yongcheng Yang
 <yoyang@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-nfs@...r.kernel.org
Subject: Re: [PATCH] lockd: add netlink control interface

On Wed, 08 Jan 2025 16:00:15 -0500 Jeff Layton wrote:
> The legacy rpc.nfsd tool will set the nlm_grace_period if the NFSv4
> grace period is set. nfsdctl is missing this functionality, so add a new
> netlink control interface for lockd that it can use. For now, it only
> allows setting the grace period, and the tcp and udp listener ports.
> 
> lockd currently uses module parameters and sysctls for configuration, so
> all of its settings are global. With this change, lockd now tracks these
> values on a per-net-ns basis. It will only fall back to using the global
> values if any of them are 0.
> 
> Finally, as a backward compatability measure, if updating the nlm
> settings in the init_net namespace, also update the legacy global
> values to match.

Netlinky stuff LGTM, FWIW!

To encourage more doc: properties I should point out that we
render the specs on docs.kernel.org, now ;)
https://docs.kernel.org/next/networking/netlink_spec/nfsd.html