netdev - Re: [PATCH net-next, v4] netlink: support dumping IPv4 multicast addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e01b76a-d785-4dd7-8892-504989bfd4ce@kernel.org>
Date: Thu, 9 Jan 2025 10:09:50 -0700
From: David Ahern <dsahern@...nel.org>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 roopa@...ulusnetworks.com, jiri@...nulli.us, stephen@...workplumber.org,
 jimictw@...gle.com, prohr@...gle.com, liuhangbin@...il.com,
 nicolas.dichtel@...nd.com, andrew@...n.ch, netdev@...r.kernel.org,
 Maciej Żenczykowski <maze@...gle.com>,
 Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next, v4] netlink: support dumping IPv4 multicast
 addresses

On 1/9/25 8:52 AM, Yuyang Huang wrote:
>> my comment meant that this `type` should be removed and the wrappers
>> below just call the intended function. No need for the extra layers.
> 
> Sorry, I still do not fully understand the suggestions.
> 
> In the current inet_dump_ifaddr() function, there are two places where
> in_dev_dump_addr() is called.
> 

nevermind. I forgot how IPv6 address dumps are coded, and keeping the 2
protocols aligned is best. So, I guess you just need to resolve the
failures Paolo noted.