netdev - Re: [PATCH net] ipv4: route: fix drop reason being overridden in ip_route_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4BN4EHgHcLhxoz1@hog>
Date: Thu, 9 Jan 2025 23:29:52 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Antoine Tenart <atenart@...nel.org>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Menglong Dong <menglong8.dong@...il.com>
Subject: Re: [PATCH net] ipv4: route: fix drop reason being overridden in
 ip_route_input_slow

2025-01-08, 17:57:15 +0100, Antoine Tenart wrote:
> When jumping to 'martian_destination' a drop reason is always set but
> that label falls-through the 'e_nobufs' one, overriding the value.
[...]
> A 'goto out' is clearly missing now after 'martian_destination' to avoid
> overriding the drop reason.
> 
> Fixes: 5b92112acd8e ("net: ip: make ip_route_input_slow() return drop reasons")
> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
> Cc: Menglong Dong <menglong8.dong@...il.com>
> Signed-off-by: Antoine Tenart <atenart@...nel.org>
> ---
>  net/ipv4/route.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Antoine.

-- 
Sabrina