netdev - Re: [PATCH net-next v4 1/6] net: move ARFS rmap management to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3456c7b8-058f-4b5d-8a68-b815e561a5f3@intel.com>
Date: Fri, 10 Jan 2025 08:13:34 -0700
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: Simon Horman <horms@...nel.org>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<andrew+netdev@...n.ch>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <davem@...emloft.net>, <michael.chan@...adcom.com>,
	<tariqt@...dia.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <jdamato@...tly.com>, <shayd@...dia.com>,
	<akpm@...ux-foundation.org>, <shayagr@...zon.com>,
	<kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net-next v4 1/6] net: move ARFS rmap management to core



On 2025-01-10 4:59 a.m., Simon Horman wrote:
> On Thu, Jan 09, 2025 at 04:31:02PM -0700, Ahmed Zaki wrote:
>> Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should
>> set the flag via netif_enable_cpu_rmap() and core will allocate and manage
>> the ARFS rmap. Freeing the rmap is also done by core when the netdev is
>> freed.
>>
>> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> 
> ...
> 
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 1812564b5204..acf20191e114 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -2398,6 +2398,9 @@ struct net_device {
>>   	struct lock_class_key	*qdisc_tx_busylock;
>>   	bool			proto_down;
>>   	bool			threaded;
>> +#ifdef CONFIG_RFS_ACCEL
>> +	bool			rx_cpu_rmap_auto;
>> +#endif
> 
> nit: rx_cpu_rmap_auto should also be added to the Kernel doc for
>       struct net_device.
>

Hi Simon,

Sure. Will also do the same for "rq_affinity_auto" in patch 3.