netdev - Re: [PATCH net-next 1/2] tcp: add drop_reason support to tcp_disordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynrCQzzibTSyoo1uz7eWiTuj7m+cLwL1LSfNp7PZtm+qQ@mail.gmail.com>
Date: Fri, 10 Jan 2025 11:11:14 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] tcp: add drop_reason support to tcp_disordered_ack()

On Fri, Jan 10, 2025 at 9:33 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Following patch is adding a new drop_reason to tcp_validate_incoming().
>
> Change tcp_disordered_ack() to not return a boolean anymore,
> but a drop reason.
>
> Change its name to tcp_disordered_ack_check()
>
> Refactor tcp_validate_incoming() to ease the code
> review of the following patch, and reduce indentation
> level.
>
> This patch is a refactor, with no functional change.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/tcp_input.c | 79 ++++++++++++++++++++++++--------------------
>  1 file changed, 44 insertions(+), 35 deletions(-)
>

Looks great to me. Thanks, Eric!

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

neal