netdev - Re: [PATCH net-next 1/2] tcp: add drop_reason support to tcp_disordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250110180134.57158-1-kuniyu@amazon.com>
Date: Sat, 11 Jan 2025 03:01:34 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <ncardwell@...gle.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next 1/2] tcp: add drop_reason support to tcp_disordered_ack()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 10 Jan 2025 14:33:14 +0000
> Following patch is adding a new drop_reason to tcp_validate_incoming().
> 
> Change tcp_disordered_ack() to not return a boolean anymore,
> but a drop reason.
> 
> Change its name to tcp_disordered_ack_check()
> 
> Refactor tcp_validate_incoming() to ease the code
> review of the following patch, and reduce indentation
> level.
> 
> This patch is a refactor, with no functional change.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>