netdev - Re: [PATCH net-next 12/13] ice: implement low latency PHY timer updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250109181823.77f44c69@kernel.org>
Date: Thu, 9 Jan 2025 18:18:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org, Jacob Keller
 <jacob.e.keller@...el.com>, anton.nadezhdin@...el.com,
 przemyslaw.kitszel@...el.com, milena.olech@...el.com,
 arkadiusz.kubalewski@...el.com, richardcochran@...il.com, Karol Kolacinski
 <karol.kolacinski@...el.com>, Rinitha S <sx.rinitha@...el.com>
Subject: Re: [PATCH net-next 12/13] ice: implement low latency PHY timer
 updates

On Wed,  8 Jan 2025 14:17:49 -0800 Tony Nguyen wrote:
> +	spin_lock_irqsave(&params->atqbal_wq.lock, flags);
> +
> +	/* Wait for any pending in-progress low latency interrupt */
> +	err = wait_event_interruptible_locked_irq(params->atqbal_wq,

Don't you need an irqsave() flavor of
wait_event_interruptible_locked_irq() for this to work correctly? 🤔️
-- 
pw-bot: cr