netdev - Re: [PATCH net-next 5/5] net: phylink: provide fixed state for 1000base-X and 2500base-X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a54b564b-4f88-4783-9e8a-72289ce11c04@gmail.com>
Date: Fri, 10 Jan 2025 09:04:56 +0100
From: Eric Woudstra <ericwouds@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Alexander Couzens <lynxis@...0.eu>, Alexander Duyck <alexanderduyck@...com>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ar__n__ __NAL <arinc.unal@...nc9.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Daniel Golle <daniel@...rotopia.org>,
 Daniel Machon <daniel.machon@...rochip.com>,
 "David S. Miller" <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>,
 Ioana Ciornei <ioana.ciornei@....com>, Jakub Kicinski <kuba@...nel.org>,
 Jose Abreu <Jose.Abreu@...opsys.com>, kernel-team@...a.com,
 Lars Povlsen <lars.povlsen@...rochip.com>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Madalin Bucur <madalin.bucur@....com>,
 Marcin Wojtas <marcin.s.wojtas@...il.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Michal Simek <michal.simek@....com>, netdev@...r.kernel.org,
 Nicolas Ferre <nicolas.ferre@...rochip.com>, Paolo Abeni
 <pabeni@...hat.com>, Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
 Sean Anderson <sean.anderson@...o.com>, Sean Wang <sean.wang@...iatek.com>,
 Steen Hegelund <Steen.Hegelund@...rochip.com>,
 Taras Chornyi <taras.chornyi@...ision.eu>, UNGLinuxDriver@...rochip.com,
 Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 5/5] net: phylink: provide fixed state for
 1000base-X and 2500base-X

On 1/9/25 4:15 PM, Russell King (Oracle) wrote:
> When decoding clause 22 state, if in-band is disabled and using either
> 1000base-X or 2500base-X, rather than reporting link-down, we know the
> speed, and we only support full duplex. Pause modes taken from XPCS.
> 
> This fixes a problem reported by Eric Woudstra.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c

After changing 'if (pcs->neg_mode)' to 'if (pcs && pcs->neg_mode)' in
patch 1/5, I have tested this patch-set and I get link up.

Tested-by: Eric Woudstra <ericwouds@...il.com>