netdev - Re: [PATCH v2 net] r8169: remove redundant hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5335da20-7c44-4178-b30b-779500b5c0bb@intel.com>
Date: Fri, 10 Jan 2025 16:53:23 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Realtek linux nic maintainers
	<nic_swsd@...ltek.com>, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, David Miller
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Simon Horman
	<horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] r8169: remove redundant hwmon support



On 1/9/2025 10:45 PM, Heiner Kallweit wrote:
> On 10.01.2025 02:14, Jacob Keller wrote:
>>
>>
>> On 1/9/2025 2:43 PM, Heiner Kallweit wrote:
>>> The temperature sensor is actually part of the integrated PHY and available
>>> also on the standalone versions of the PHY. Therefore hwmon support will
>>> be added to the Realtek PHY driver and can be removed here.
>>>
>>> Fixes: 1ffcc8d41306 ("r8169: add support for the temperature sensor being available from RTL8125B")
>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>>> ---
>>
>> Can you explain what user-facing issues this fixes? Do we get conflicts
>> when multiple hwmon sensors are registered? I'm not sure this counts as
>> a 'net' fix, unless we can identify the user-facing behavior that is
>> problematic?
> 
> The same sensor would be exposed twice, by the MAC and the PHY driver.
> Support in the MAC driver was added for 6.13, so it's still in the rc
> version only and not yet part of a released kernel version.
> 

I guess I'm failing to understand what the user repercussions of having
multiple sensors would be?

I suppose that it is confusing and could lead to issues when userspace
is checking or controlling the sensor, and fixing this via net before it
makes it into a full release is good.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>