netdev - Re: [PATCH v2 net-next 3/3] tcp: add LINUX_MIB_PAWS_OLD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynzjcW4gCf+=O=gn0HBV40m8jBwmeVBTqMbswSmcuON4w@mail.gmail.com>
Date: Mon, 13 Jan 2025 09:28:27 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Jason Xing <kerneljasonxing@...il.com>, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 3/3] tcp: add LINUX_MIB_PAWS_OLD_ACK SNMP counter

On Mon, Jan 13, 2025 at 8:56 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Prior patch in the series added TCP_RFC7323_PAWS_ACK drop reason.
>
> This patch adds the corresponding SNMP counter, for folks
> using nstat instead of tracing for TCP diagnostics.
>
> nstat -az | grep PAWSOldAck
>
> Suggested-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/net/dropreason-core.h | 1 +
>  include/uapi/linux/snmp.h     | 1 +
>  net/ipv4/proc.c               | 1 +
>  net/ipv4/tcp_input.c          | 7 ++++---
>  4 files changed, 7 insertions(+), 3 deletions(-)

Looks great to me. Thanks, Eric!

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

neal