netdev - Re: [PATCH net-next v2 0/5] net: phylink: fix PCS without autoneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250113172255.3772dd6a@fedora.home>
Date: Mon, 13 Jan 2025 17:22:55 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Alexander Couzens <lynxis@...0.eu>, Alexander Duyck
 <alexanderduyck@...com>, Andrew Lunn <andrew+netdev@...n.ch>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Arınç ÜNAL <arinc.unal@...nc9.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, Daniel Golle <daniel@...rotopia.org>, Daniel
 Machon <daniel.machon@...rochip.com>, "David S. Miller"
 <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>, Eric Dumazet
 <edumazet@...gle.com>, Eric Woudstra <ericwouds@...il.com>, Florian
 Fainelli <florian.fainelli@...adcom.com>, Horatiu Vultur
 <horatiu.vultur@...rochip.com>, Ioana Ciornei <ioana.ciornei@....com>,
 Jakub Kicinski <kuba@...nel.org>, Jose Abreu <Jose.Abreu@...opsys.com>,
 kernel-team@...a.com, Lars Povlsen <lars.povlsen@...rochip.com>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Madalin Bucur <madalin.bucur@....com>, Marcin Wojtas
 <marcin.s.wojtas@...il.com>, Matthias Brugger <matthias.bgg@...il.com>,
 Michal Simek <michal.simek@....com>, netdev@...r.kernel.org, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Paolo Abeni <pabeni@...hat.com>, Radhey
 Shyam Pandey <radhey.shyam.pandey@....com>, Sean Anderson
 <sean.anderson@...o.com>, Sean Wang <sean.wang@...iatek.com>, Steen
 Hegelund <Steen.Hegelund@...rochip.com>, Taras Chornyi
 <taras.chornyi@...ision.eu>, UNGLinuxDriver@...rochip.com, Vladimir Oltean
 <olteanv@...il.com>
Subject: Re: [PATCH net-next v2 0/5] net: phylink: fix PCS without autoneg

Hello Russell,

On Mon, 13 Jan 2025 09:22:15 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> Hi,
> 
> Eric Woudstra reported that a PCS attached using 2500base-X does not
> see link when phylink is using in-band mode, but autoneg is disabled,
> despite there being a valid 2500base-X signal being received. We have
> these settings:
> 
> 	act_link_an_mode = MLO_AN_INBAND
> 	pcs_neg_mode = PHYLINK_PCS_NEG_INBAND_DISABLED
> 
> Eric diagnosed it to phylink_decode_c37_word() setting state->link
> false because the full-duplex bit isn't set in the non-existent link
> partner advertisement word (which doesn't exist because in-band
> autoneg is disabled!)
> 
> The test in phylink_mii_c22_pcs_decode_state() is supposed to catch
> this state, but since we converted PCS to use neg_mode, testing the
> Autoneg in the local advertisement is no longer sufficient - we need
> to be looking at the neg_mode, which currently isn't provided.
> 
> We need to provide this via the .pcs_get_state() method, and this
> will require modifying all PCS implementations to add the extra
> argument to this method.
> 
> Patch 1 uses the PCS neg_mode in phylink_mac_pcs_get_state() to correct
> the now obsolute usage of the Autoneg bit in the advertisement.
> 
> Patch 2 passes neg_mode into the .pcs_get_state() method, and updates
> all users.
> 
> Patch 3 adds neg_mode as an argument to the various clause 22 state
> decoder functions in phylink, modifying drivers to pass the neg_mode
> through.
> 
> Patch 4 makes use of phylink_mii_c22_pcs_decode_state() rather than
> using the Autoneg bit in the advertising field.
> 
> Patch 5 may be required for Eric's case - it ensures that we report
> the correct state for interface types that we support only one set
> of modes for when autoneg is disabled.
> 
> Changes in v2:
> - Add test for NULL pcs in patch 1
> 
> I haven't added Eric's t-b because I used a different fix in patch 1.

I stumbled on that issue last friday as well, with a MCBin and a
device I'm working on, using 1000BaseX with autoneg disabled. I didn't
get time to investigate back then, but reading this series it was
definitely that exact problem I was facing.

I missed your V1 and I just tested that V2, the problem is gone :)
Thanks !

The code LGTM to the best of my knowledge, so

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime