netdev - Re: [PATCH net-next v2 1/2] net: remove init_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4WMl6PvgRFRQEMm@LQ3V64L9R2>
Date: Mon, 13 Jan 2025 13:58:47 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	matttbe@...nel.org, martineau@...nel.org, geliang@...nel.org,
	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	mptcp@...ts.linux.dev
Subject: Re: [PATCH net-next v2 1/2] net: remove init_dummy_netdev()

On Sun, Jan 12, 2025 at 04:34:55PM -0800, Jakub Kicinski wrote:
> init_dummy_netdev() can initialize statically declared or embedded
> net_devices. Such netdevs did not come from alloc_netdev_mqs().
> After recent work by Breno, there are the only two cases where
> we have do that.
> 
> Switch those cases to alloc_netdev_mqs() and delete init_dummy_netdev().
> Dealing with static netdevs is not worth the maintenance burden.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2: change of plan, delete init_dummy_netdev() completely
> v1: https://lore.kernel.org/20250111065955.3698801-1-kuba@kernel.org
> ---
> CC: matttbe@...nel.org
> CC: martineau@...nel.org
> CC: geliang@...nel.org
> CC: steffen.klassert@...unet.com
> CC: herbert@...dor.apana.org.au
> CC: mptcp@...ts.linux.dev
> ---
>  include/linux/netdevice.h |  1 -
>  net/core/dev.c            | 22 ----------------------
>  net/mptcp/protocol.c      |  8 +++++---
>  net/xfrm/xfrm_input.c     |  9 ++++++---
>  4 files changed, 11 insertions(+), 29 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>