netdev - Re: [PATCH net-next v2 5/5] tsnep: Add PHY loopback selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <543fd272-4727-4f13-bec5-9a61bc460066@lunn.ch>
Date: Mon, 13 Jan 2025 23:06:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/5] tsnep: Add PHY loopback selftests

> +static bool set_speed(struct tsnep_adapter *adapter, int speed)
> +{
> +	struct ethtool_link_ksettings cmd;
> +	int retval;
> +
> +	retval = tsnep_ethtool_ops.get_link_ksettings(adapter->netdev, &cmd);
> +	if (retval)
> +		return false;

Why go via tsnep_ethtool_ops. Since this is all internal to the
driver, you know how this callback is implemented.

	Andrew