netdev - Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading temperature and voltage sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4Yg79d4KoBrNGFG@mev-dev.igk.intel.com>
Date: Tue, 14 Jan 2025 09:31:43 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	kernel-team@...a.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com,
	kalesh-anakkur.purayil@...adcom.com, linux@...ck-us.net,
	mohsin.bashr@...il.com, jdelvare@...e.com, horms@...nel.org,
	suhui@...china.com, linux-kernel@...r.kernel.org,
	vadim.fedorenko@...ux.dev, linux-hwmon@...r.kernel.org,
	sanmanpradhan@...a.com
Subject: Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading
 temperature and voltage sensors

On Mon, Jan 13, 2025 at 04:07:04PM -0800, Sanman Pradhan wrote:
> Add support for reading temperature and voltage sensor data from firmware
> by implementing a new TSENE message type and response parsing. This adds
> message handler infrastructure to transmit sensor read requests and parse
> responses. The sensor data will be exposed through the driver's hwmon interface.
> 
> Signed-off-by: Sanman Pradhan <sanman.p211993@...il.com>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 89 ++++++++++++++++++++-
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.h  | 15 ++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 72 +++++++++++++++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.h |  7 ++
>  4 files changed, 179 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> index 320615a122e4..bbc7c1c0c37e 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> @@ -228,9 +228,9 @@ static void fbnic_mbx_process_tx_msgs(struct fbnic_dev *fbd)
>  	tx_mbx->head = head;
>  }
> 

[...]

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> --
> 2.43.5