netdev - Re: [PATCH net-next 1/2] net: un-export init_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH-L+nOBd4u4n4hv6p4y5KDeLbw5LX6iNtAbXB1NPLP6Q8tSHg@mail.gmail.com>
Date: Tue, 14 Jan 2025 14:57:46 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	horms@...nel.org
Subject: Re: [PATCH net-next 1/2] net: un-export init_dummy_netdev()

On Mon, Jan 13, 2025 at 10:22 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Mon, Jan 13, 2025 at 10:44:37AM +0530, Kalesh Anakkur Purayil wrote:
> > On Sat, Jan 11, 2025 at 12:30 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > >
> > > There are no in-tree module callers of init_dummy_netdev(), AFAICT.
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > > ---
> > >  net/core/dev.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > index 1a90ed8cc6cc..23e7f6a3925b 100644
> > > --- a/net/core/dev.c
> > > +++ b/net/core/dev.c
> > > @@ -10782,7 +10782,6 @@ void init_dummy_netdev(struct net_device *dev)
> > >         memset(dev, 0, sizeof(struct net_device));
> > >         init_dummy_netdev_core(dev);
> > >  }
> > > -EXPORT_SYMBOL_GPL(init_dummy_netdev);
> > >
> > >  /**
> > >   *     register_netdev - register a network device
> > > --
> > > 2.47.1
> > >
> > >
> > I can see that "net/xfrm/xfrm_input.c" and "net/mptcp/protocol.c" are
> > invoking init_dummy_netdev() in the init routines.
>
> I thought that initially. And then i checked that they can only be
> built in. You only need exports for modules.

Got it, thank you Andrew for the clarification.
>
>       Andrew



-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)