netdev - Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading temperature and voltage sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5252ffe7-56a7-4be7-9fdb-6d0b810ebfb5@lunn.ch>
Date: Tue, 14 Jan 2025 02:19:08 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	kernel-team@...a.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com,
	kalesh-anakkur.purayil@...adcom.com, linux@...ck-us.net,
	mohsin.bashr@...il.com, jdelvare@...e.com, horms@...nel.org,
	suhui@...china.com, linux-kernel@...r.kernel.org,
	vadim.fedorenko@...ux.dev, linux-hwmon@...r.kernel.org,
	sanmanpradhan@...a.com
Subject: Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading
 temperature and voltage sensors

> @@ -50,6 +50,10 @@ struct fbnic_fw_completion {
>  	struct kref ref_count;
>  	int result;
>  	union {
> +		struct {
> +			s32 millivolts;
> +			s32 millidegrees;
> +		} tsene;
>  	} u;
>  };

Why have a union which only has one member?

	Andrew