netdev - Re: [PATCH net-next 07/11] net: make netdev netlink ops hold netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLJ90iuFWRRKO3BVu=CZWDxzLYdQCh7LgSRpqes=guEnw@mail.gmail.com>
Date: Tue, 14 Jan 2025 14:16:46 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, horms@...nel.org, jdamato@...tly.com
Subject: Re: [PATCH net-next 07/11] net: make netdev netlink ops hold netdev_lock()

On Tue, Jan 14, 2025 at 4:51 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> In prep for dropping rtnl_lock, start locking netdev->lock in netlink
> genl ops. We need to be using netdev->up instead of flags & IFF_UP.
>
> We can remove the RCU lock protection for the NAPI since NAPI list
> is protected by netdev->lock already.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>