netdev - Re: 回覆: [External] Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGfYmwXKyWrWm5z1Lra0_wX8iVfT8p9BHd3SWZPSvkZ1qfKqLA@mail.gmail.com>
Date: Tue, 14 Jan 2025 09:56:13 +0800
From: Potin Lai <potin.lai.pt@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paul Fertser <fercerpav@...il.com>, Potin Lai (賴柏廷 ) <Potin.Lai@...ntatw.com>, 
	Samuel Mendoza-Jonas <sam@...dozajonas.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Ivan Mikhaylov <fr0st61te@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"stable@...r.kernel.org" <stable@...r.kernel.org>, 
	Cosmo Chou ( 周楷培) <Cosmo.Chou@...ntatw.com>, 
	"patrick@...cx.xyz" <patrick@...cx.xyz>, Cosmo Chou <chou.cosmo@...il.com>
Subject: Re: 回覆: [External] Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

On Tue, Jan 14, 2025 at 5:19 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat, 11 Jan 2025 19:12:51 +0800 Potin Lai wrote:
> > > > Thanks for the new patch.
> > > > I am currently tied up with other tasks, but I’ll make sure to test
> > > > it as soon as possible and share the results with you.
> > >
> > > Understood, would you be able to test it by January 13th?
> > > Depending on how long we need to wait we may be better off
> > > applying the patch already or waiting with committing..
> >
> > Hi Jakub & Paul,
> >
> > I had a test yesterday, the patch is working and the kernel panic does
> > not happen any more, but we notice sometimes the config_apply_mac
> > state runs before the gma command is handled.
> >
> > Cosmo helped me to find a potential state handling issue, and I
> > submitted the v2 version.
> > Please kindly have a look at v2 version with the link below.
> > v2: https://lore.kernel.org/all/20250111-fix-ncsi-mac-v2-0-838e0a1a233a@gmail.com/
>
> Is there any reason why you reposted Paul's patch?
> Patch 2 looks like a fix for a separate issue (but for the same
> use case), am I wrong?
Sorry, I thought the second patch needs to be followed by the first patch.
Yes, these 2 patches are fixing different issues, I will remove Paul's
patch in the next version (v3).

>
> Also one thing you have not done is to provide the Tested-by: tag
> on Paul's patch :)

Tested-by: Potin Lai <potin.lai.pt@...il.com>