netdev - Re: [PATCH net-next v3 4/4] net: ngbe: Add support for 1PPS and TOD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4aO7v0NFe-aYaFk@hoboy.vegasvil.org>
Date: Tue, 14 Jan 2025 08:21:02 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
	horms@...nel.org, jacob.e.keller@...el.com, netdev@...r.kernel.org,
	vadim.fedorenko@...ux.dev, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 4/4] net: ngbe: Add support for 1PPS and TOD

On Mon, Jan 13, 2025 at 02:30:24PM +0800, Jiawen Wu wrote:
> On Sun, Jan 12, 2025 1:16 AM, Richard Cochran wrote:
> > ... that appears to be hard coding a period of one second?
> 
> Yes. We only want to support 1pps functionality.

Ok, then you need to check the value of `perout.period`.

> > > +	wx->pps_width = rq->perout.period.nsec;
> > > +	wx->ptp_setup_sdp(wx);
> > 
> > And this ^^^ is taking the dialed period and turning into the duty
> > cycle?
> 
> We try to use "width",  which means the time from the rising edge to the falling edge.

You should use the passed duty cycle for that.

Thanks,
Richard