lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202501150051.z1HfVwib-lkp@intel.com>
Date: Wed, 15 Jan 2025 01:06:26 +0800
From: kernel test robot <lkp@...el.com>
To: Xin Long <lucien.xin@...il.com>, network dev <netdev@...r.kernel.org>
Cc: oe-kbuild-all@...ts.linux.dev, davem@...emloft.net, kuba@...nel.org,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	ast@...erby.net, Shuang Li <shuali@...hat.com>
Subject: Re: [PATCHv2 net] net: sched: refine software bypass handling in
 tc_run

Hi Xin,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Xin-Long/net-sched-refine-software-bypass-handling-in-tc_run/20250114-025301
base:   net/main
patch link:    https://lore.kernel.org/r/17d459487b61c5d0276a01a3bc1254c6432b5d12.1736793775.git.lucien.xin%40gmail.com
patch subject: [PATCHv2 net] net: sched: refine software bypass handling in tc_run
config: i386-buildonly-randconfig-004-20250114 (https://download.01.org/0day-ci/archive/20250115/202501150051.z1HfVwib-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250115/202501150051.z1HfVwib-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501150051.z1HfVwib-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/static_key.h:1,
                    from arch/x86/include/asm/nospec-branch.h:6,
                    from arch/x86/include/asm/irqflags.h:9,
                    from include/linux/irqflags.h:18,
                    from arch/x86/include/asm/special_insns.h:10,
                    from arch/x86/include/asm/processor.h:25,
                    from arch/x86/include/asm/timex.h:5,
                    from include/linux/timex.h:67,
                    from include/linux/time32.h:13,
                    from include/linux/time.h:60,
                    from include/linux/stat.h:19,
                    from include/linux/module.h:13,
                    from net/sched/cls_api.c:12:
   net/sched/cls_api.c: In function 'tcf_proto_destroy':
>> net/sched/cls_api.c:422:44: error: 'tcf_bypass_check_needed_key' undeclared (first use in this function)
     422 |                         static_branch_dec(&tcf_bypass_check_needed_key);
         |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:525:63: note: in definition of macro 'static_branch_dec'
     525 | #define static_branch_dec(x)            static_key_slow_dec(&(x)->key)
         |                                                               ^
   net/sched/cls_api.c:422:44: note: each undeclared identifier is reported only once for each function it appears in
     422 |                         static_branch_dec(&tcf_bypass_check_needed_key);
         |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:525:63: note: in definition of macro 'static_branch_dec'
     525 | #define static_branch_dec(x)            static_key_slow_dec(&(x)->key)
         |                                                               ^
   net/sched/cls_api.c: In function 'tc_new_tfilter':
   net/sched/cls_api.c:2385:52: error: 'tcf_bypass_check_needed_key' undeclared (first use in this function)
    2385 |                                 static_branch_inc(&tcf_bypass_check_needed_key);
         |                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:301:74: note: in definition of macro 'static_key_slow_inc'
     301 | #define static_key_slow_inc(key)        static_key_fast_inc_not_disabled(key)
         |                                                                          ^~~
   net/sched/cls_api.c:2385:33: note: in expansion of macro 'static_branch_inc'
    2385 |                                 static_branch_inc(&tcf_bypass_check_needed_key);
         |                                 ^~~~~~~~~~~~~~~~~


vim +/tcf_bypass_check_needed_key +422 net/sched/cls_api.c

   415	
   416	static void tcf_proto_destroy(struct tcf_proto *tp, bool rtnl_held,
   417				      bool sig_destroy, struct netlink_ext_ack *extack)
   418	{
   419		tp->ops->destroy(tp, rtnl_held, extack);
   420		if (tp->usesw && tp->counted) {
   421			if (!atomic_dec_return(&tp->chain->block->useswcnt))
 > 422				static_branch_dec(&tcf_bypass_check_needed_key);
   423			tp->counted = false;
   424		}
   425		if (sig_destroy)
   426			tcf_proto_signal_destroyed(tp->chain, tp);
   427		tcf_chain_put(tp->chain);
   428		module_put(tp->ops->owner);
   429		kfree_rcu(tp, rcu);
   430	}
   431	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ