netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow-path in LAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865BE350ED754A603320D1E8F182@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 14 Jan 2025 18:32:54 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow-path in
 LAG

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Buvaneswaran, Sujai
> Sent: Monday, January 13, 2025 9:17 AM
> To: Marcin Szycik <marcin.szycik@...ux.intel.com>; intel-wired-
> lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow-path in LAG
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> > Of Marcin Szycik
> > Sent: Friday, January 3, 2025 12:38 AM
> > To: intel-wired-lan@...ts.osuosl.org
> > Cc: netdev@...r.kernel.org; Marcin Szycik
> > <marcin.szycik@...ux.intel.com>; Michal Swiatkowski
> > <michal.swiatkowski@...ux.intel.com>
> > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev
> > slow-path in LAG
> >
> > Ever since removing switchdev control VSI and using PF for port
> > representor Tx/Rx, switchdev slow-path has been working improperly
> > after failover in SR- IOV LAG. LAG assumes that the first uplink to be
> > added to the aggregate will own VFs and have switchdev configured.
> > After failing-over to the other uplink, representors are still
> > configured to Tx through the uplink they are set up on, which fails because that
> uplink is now down.
> >
> > On failover, update all PRs on primary uplink to use the currently
> > active uplink for Tx. Call netif_keep_dst(), as the secondary uplink
> > might not be in switchdev mode. Also make sure to call
> > ice_eswitch_set_target_vsi() if uplink is in LAG.
> >
> > On the Rx path, representors are already working properly, because
> > default Tx from VFs is set to PF owning the eswitch. After failover
> > the same PF is receiving traffic from VFs, even though link is down.
> >
> > Fixes: defd52455aee ("ice: do Tx through PF netdev in slow-path")
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_lag.c  | 27
> > +++++++++++++++++++++++ drivers/net/ethernet/intel/ice/ice_txrx.c |  4
> > +++-
> >  2 files changed, 30 insertions(+), 1 deletion(-)
> >


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>