netdev - Re: [PATCH net-next v2 5/5] tsnep: Add PHY loopback selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8944a472-7cfe-4f20-8da3-75ae5737ff94@engleder-embedded.com>
Date: Tue, 14 Jan 2025 21:36:07 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/5] tsnep: Add PHY loopback selftests

On 13.01.25 23:08, Andrew Lunn wrote:
> On Fri, Jan 10, 2025 at 03:48:28PM +0100, Gerhard Engleder wrote:
>> Add loopback selftests on PHY level. This enables quick testing of
>> loopback functionality to ensure working loopback for testing.
> 
> You don't appear to be sending any packets. So how do you know
> loopback is actually working? I'm not sure this is a useful test.

Yes with sending packets it would be a better test. This test would
detect if loopback link is not established with the requested speed
as it is the case since 6ff3cddc365b ("net: phylib: do not disable
autoneg for fixed speeds >= 1G").

I will check if sending packets can be added.

Thank you for the review!

Gerhard