netdev - RE: [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock before accessing the xn->salt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5911B26BFC9FD45342B6B3BABA182@MW4PR11MB5911.namprd11.prod.outlook.com>
Date: Tue, 14 Jan 2025 06:58:42 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: Brian Vazquez <brianvv@...gle.com>, Brian Vazquez
	<brianvv.kernel@...il.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: David Decotigny <decot@...gle.com>, Vivek Kumar <vivekmr@...gle.com>,
	"Singhai, Anjali" <anjali.singhai@...el.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	Manoj Vishwanathan <manojvishy@...gle.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "Linga, Pavan Kumar"
	<pavan.kumar.linga@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock
 before accessing the xn->salt


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Brian Vazquez
> Sent: Monday, December 16, 2024 8:28 AM
> To: Brian Vazquez <brianvv.kernel@...il.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; David S. Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; intel-wired-lan@...ts.osuosl.org
> Cc: David Decotigny <decot@...gle.com>; Vivek Kumar
> <vivekmr@...gle.com>; Singhai, Anjali <anjali.singhai@...el.com>;
> Samudrala, Sridhar <sridhar.samudrala@...el.com>; linux-
> kernel@...r.kernel.org; netdev@...r.kernel.org; Tantilov, Emil S
> <emil.s.tantilov@...el.com>; Manoj Vishwanathan
> <manojvishy@...gle.com>; Brian Vazquez <brianvv@...gle.com>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@...el.com>
> Subject: [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock before
> accessing the xn->salt
> 
> From: Manoj Vishwanathan <manojvishy@...gle.com>
> 
> The transaction salt was being accessed before acquiring the
> idpf_vc_xn_lock when idpf has to forward the virtchnl reply.
> 
> Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
> Signed-off-by: Manoj Vishwanathan <manojvishy@...gle.com>
> Signed-off-by: David Decotigny <decot@...gle.com>
> Signed-off-by: Brian Vazquez <brianvv@...gle.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>