netdev - Re: [PATCH v13 1/3] tools: ynl-gen: add trampolines for sock-priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBPYPiFY1YYXvo+uf3=0mmahFp3qTBbW=dxp11MsPf68j43Lg@mail.gmail.com>
Date: Wed, 15 Jan 2025 08:44:37 -0800
From: Li Li <dualli@...omium.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dualli@...gle.com, corbet@....net, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, donald.hunter@...il.com, 
	gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com, 
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org, 
	cmllamas@...gle.com, surenb@...gle.com, arnd@...db.de, masahiroy@...nel.org, 
	bagasdotme@...il.com, horms@...nel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org, hridya@...gle.com, 
	smoreland@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH v13 1/3] tools: ynl-gen: add trampolines for sock-priv

On Wed, Jan 15, 2025 at 8:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 15 Jan 2025 02:29:48 -0800 Li Li wrote:
> > From: Li Li <dualli@...gle.com>
> >
> > This fixes the CFI failure at genl-sk_priv_get().
> >
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Li Li <dualli@...gle.com>
>
> No, no, this is a fix. We'll try to send it to Linus tomorrow.

Thank you for prioritizing the fix!

There's another trivial issue which I just realized after sending out the
patchset. When "sock-priv" is a pointer (like the example below), ynl-gen
generates ugly code and fails scripts/checkpatch.

Should I use typedef instead although it seems discouraged according to
https://www.kernel.org/doc/html/latest/process/coding-style.html?

YAML:
+  sock-priv: struct binder_context *

==>

Generated code:
+void binder_nl_sock_priv_init(struct binder_context * *priv);
                                                     ^^^ extra space
+void binder_nl_sock_priv_destroy(struct binder_context * *priv);
                                                        ^^^ extra space