netdev - Re: [PATCH net] netdev: avoid CFI problems with sock priv helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izOYYe2yrPia2_X-8qxznpurhKz-XOsdZ0tjGBFoEOcg8Q@mail.gmail.com>
Date: Wed, 15 Jan 2025 09:01:34 -0800
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	Li Li <dualli@...omium.org>, donald.hunter@...il.com, sdf@...ichev.me
Subject: Re: [PATCH net] netdev: avoid CFI problems with sock priv helpers

On Wed, Jan 15, 2025 at 8:14 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Li Li reports that casting away callback type may cause issues
> for CFI. Let's generate a small wrapper for each callback,
> to make sure compiler sees the anticipated types.
>
> Reported-by: Li Li <dualli@...omium.org>
> Link: https://lore.kernel.org/CANBPYPjQVqmzZ4J=rVQX87a9iuwmaetULwbK_5_3YWk2eGzkaA@mail.gmail.com
> Fixes: 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks Jakub,

Reviewed-by: Mina Almasry <almasrymina@...gle.com>