netdev - Re: [PATCH v2 net-next 00/11] af_unix: Set skb drop reason in every kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4fynNxk3FJ8BCWA@LQ3V64L9R2>
Date: Wed, 15 Jan 2025 09:38:36 -0800
From: Joe Damato <jdamato@...tly.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Donald Hunter <donald.hunter@...hat.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 00/11] af_unix: Set skb drop reason in every
 kfree_skb() path.

On Sun, Jan 12, 2025 at 01:07:59PM +0900, Kuniyuki Iwashima wrote:
> There is a potential user for skb drop reason for AF_UNIX.
> 
> This series sets skb drop reason for every kfree_skb() path
> in AF_UNIX code.
> 
> Link: https://lore.kernel.org/netdev/CAAf2ycmZHti95WaBR3s+L5Epm1q7sXmvZ-EqCK=-oZj=45tOwQ@mail.gmail.com/
> 
> 
> Changes:
>   v2:
>     * Drop the old patch 6 to silence false-positive uninit warning
> 
>   v1: https://lore.kernel.org/netdev/20250110092641.85905-1-kuniyu@amazon.com/
> 
> 
> Kuniyuki Iwashima (11):
>   net: dropreason: Gather SOCKET_ drop reasons.
>   af_unix: Set drop reason in unix_release_sock().
>   af_unix: Set drop reason in unix_sock_destructor().
>   af_unix: Set drop reason in __unix_gc().
>   af_unix: Set drop reason in unix_stream_connect().
>   af_unix: Set drop reason in unix_stream_sendmsg().
>   af_unix: Set drop reason in queue_oob().
>   af_unix: Set drop reason in manage_oob().
>   af_unix: Set drop reason in unix_stream_read_skb().
>   af_unix: Set drop reason in unix_dgram_disconnected().
>   af_unix: Set drop reason in unix_dgram_sendmsg().
> 
>  include/net/dropreason-core.h |  46 ++++++++--
>  net/unix/af_unix.c            | 153 +++++++++++++++++++++++++---------
>  net/unix/garbage.c            |   2 +-
>  3 files changed, 154 insertions(+), 47 deletions(-)

I know there's feedback from others on some parts of this series but
I wanted to say thank you for the detailed commit messages that
include python examples.

I found that very refreshing and helpful when attempting to review
the code you've proposed; thanks for putting in the extra effort to
include those examples in the commit messages.