netdev - RE: [EXTERNAL] Re: [net-next PATCH v3 2/6] octeontx2-pf: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB5216B2D5720A252E2CCB9D3FDB192@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 15 Jan 2025 18:27:04 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Linu Cherian <lcherian@...vell.com>, Jerin
 Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com"
	<john.fastabend@...il.com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v3 2/6] octeontx2-pf: Add AF_XDP
 non-zero copy support

>> Signed-off-by: Suman Ghosh <sumang@...vell.com>
>
>This looks like a fixes that deserve its own fix tag and likely going
>trough the 'net' tree.
>
>I think you can still include in a net-next series to simplify the
>merging, but the fix tag should be added anyway.
[Suman] Okay, will add in v4
>
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> index 2859f397f99e..730f2b7742db 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> @@ -96,7 +96,7 @@ static unsigned int frag_num(unsigned int i)
>>
>>  static void otx2_xdp_snd_pkt_handler(struct otx2_nic *pfvf,
>>  				     struct otx2_snd_queue *sq,
>> -				 struct nix_cqe_tx_s *cqe)
>> +				     struct nix_cqe_tx_s *cqe)
>>  {
>>  	struct nix_send_comp_s *snd_comp = &cqe->comp;
>>  	struct sg_list *sg;
>
>For the same reasons, please move the white-space changes to a later
>patch.
[Suman] ack
>
>Thanks,
>
>Paolo