netdev - Re: [PATCH net v5] net: ethernet: sunplus: Switch to ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250114181131.16c1072f@kernel.org>
Date: Tue, 14 Jan 2025 18:11:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yeking@...54.com
Cc: andrew+netdev@...n.ch, arnd@...db.de, davem@...emloft.net,
 edumazet@...gle.com, jgg@...pe.ca, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, wellslutw@...il.com
Subject: Re: [PATCH net v5] net: ethernet: sunplus: Switch to ndo_eth_ioctl

On Mon, 13 Jan 2025 09:41:56 +0000 Yeking@...54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
> 
> The device ioctl handler no longer calls ndo_do_ioctl, but calls
> ndo_eth_ioctl to handle mii ioctls since commit a76053707dbf
> ("dev_ioctl: split out ndo_eth_ioctl"). However, sunplus still used
> ndo_do_ioctl when it was introduced. So switch to ndo_eth_ioctl. (found
> by code inspection)
> 
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")

It only occurred to me now that if we're fixing the initial commit
the PHY IOCTLs simply weren't available since day 1, so this is more 
of a new feature than a bug fix. We'll apply it for v6.14, sorry for 
the indecisiveness.