netdev - Re: [PATCH net-next v9 07/10] bnxt_en: add support for tcp-data-split ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLik_eG_DQNWdWUX1W+Z1NybzQ6+Sxu5YvHtvdcotfY_pRg@mail.gmail.com>
Date: Tue, 14 Jan 2025 22:27:07 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, netdev@...r.kernel.org, almasrymina@...gle.com, 
	donald.hunter@...il.com, corbet@....net, andrew+netdev@...n.ch, 
	hawk@...nel.org, ilias.apalodimas@...aro.org, ast@...nel.org, 
	daniel@...earbox.net, john.fastabend@...il.com, dw@...idwei.uk, 
	sdf@...ichev.me, asml.silence@...il.com, brett.creeley@....com, 
	linux-doc@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com, 
	Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v9 07/10] bnxt_en: add support for tcp-data-split
 ethtool command

On Tue, Jan 14, 2025 at 6:30 AM Taehee Yoo <ap420073@...il.com> wrote:
>
> NICs that uses bnxt_en driver supports tcp-data-split feature by the
> name of HDS(header-data-split).
> But there is no implementation for the HDS to enable by ethtool.
> Only getting the current HDS status is implemented and The HDS is just
> automatically enabled only when either LRO, HW-GRO, or JUMBO is enabled.
> The hds_threshold follows rx-copybreak value. and it was unchangeable.
>
> This implements `ethtool -G <interface name> tcp-data-split <value>`
> command option.
> The value can be <on> and <auto>.
> The value is <auto> and one of LRO/GRO/JUMBO is enabled, HDS is
> automatically enabled and all LRO/GRO/JUMBO are disabled, HDS is
> automatically disabled.
>
> HDS feature relies on the aggregation ring.
> So, if HDS is enabled, the bnxt_en driver initializes the aggregation ring.
> This is the reason why BNXT_FLAG_AGG_RINGS contains HDS condition.
>
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> Tested-by: Stanislav Fomichev <sdf@...ichev.me>
> Tested-by: Andy Gospodarek <gospo@...adcom.com>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)