netdev - Re: [PATCH net-next v6 2/6] net: libwx: Add sriov api for wangxun nics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1EFCFA3D-B0E1-4EEF-9441-A594C7796485@net-swift.com>
Date: Thu, 16 Jan 2025 17:37:10 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 helgaas@...nel.org,
 jiawenwu@...stnetic.com,
 duanqiangwen@...-swift.com
Subject: Re: [PATCH net-next v6 2/6] net: libwx: Add sriov api for wangxun
 nics



> 2025年1月15日 06:44，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Fri, 10 Jan 2025 18:27:01 +0800 Mengyuan Lou wrote:
>> +static int wx_check_sriov_allowed(struct wx *wx, int num_vfs)
>> +{
>> + u16 max_vfs;
>> +
>> + max_vfs = (wx->mac.type == wx_mac_sp) ? 63 : 7;
>> + if (num_vfs > max_vfs)
>> + return -EPERM;
> 
> You should use pci_sriov_set_totalvfs() instead of checking 
> the limit manually in the driver

Thanks for reminding.

> -- 
> pw-bot: cr
> 
>