netdev - Re: [PATCH v5 4/7] can: Add Nuvoton NCT6694 CAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdab6511-0e38-4932-a615-033d888364b1@wanadoo.fr>
Date: Thu, 16 Jan 2025 20:23:09 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Ming Yu <a0282524688@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-usb@...r.kernel.org, tmyu0@...oton.com, lee@...nel.org,
 linus.walleij@...aro.org, brgl@...ev.pl, andi.shyti@...nel.org,
 mkl@...gutronix.de, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com,
 alexandre.belloni@...tlin.com
Subject: Re: [PATCH v5 4/7] can: Add Nuvoton NCT6694 CAN support

On 16/01/2025 at 15:34, Ming Yu wrote:
> Hi Vincent,
> 
> I will remove priv->tx_skb in the next patch, but it seems that
> can_flush_echo_skb() has not been EXPORT_SYMBOL_GPL().
> 
> I would like to know if nct6694_can_clean() requires modification.

Indeed, you can can_free_echo_skb(ndev, 0, NULL) instead of
can_flush_echo_skb(ndev). That one is exported.


Yours sincerely,
Vincent Mailhol