netdev - Re: [v3 PATCH] rhashtable: Fix rhashtable_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4jyCZQOy8JMVu3Q@tuxmaker.boeblingen.de.ibm.com>
Date: Thu, 16 Jan 2025 12:48:25 +0100
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Michael Kelley <mhklinux@...look.com>, Breno Leitao <leitao@...ian.org>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>, Thomas Graf <tgraf@...g.ch>,
        Tejun Heo <tj@...nel.org>, Hao Luo <haoluo@...gle.com>,
        Josh Don <joshdon@...gle.com>, Barret Rhoden <brho@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Zaslonko Mikhail <zaslonko@...ux.ibm.com>
Subject: Re: [v3 PATCH] rhashtable: Fix rhashtable_try_insert test

On Tue, Jan 14, 2025 at 11:15:19AM +0800, Herbert Xu wrote:

Hi Herbert,

> Thanks for testing! The patch needs one more change though as
> moving the atomic_inc outside of the lock was a bad idea on my
> part.  This could cause atomic_inc/atomic_dec to be reordered
> thus resulting in an underflow.

I want to confirm that this patch fixes massive strangenesses and
few crashes observed on s390 systems, in addition to OOMs reported
by Mikhail Zaslonko earlier.

> Thanks,

Thanks!