netdev - Re: [PATCH net-next] selftests: net: give up on the cmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c522b9c-703c-4aa0-82e3-d7f9fc8d4480@intel.com>
Date: Thu, 16 Jan 2025 12:52:00 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shuah@...nel.org>, <linux-kselftest@...r.kernel.org>,
	<willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next] selftests: net: give up on the cmsg_time
 accuracy on slow machines

On 1/16/25 03:01, Jakub Kicinski wrote:
> Commit b9d5f5711dd8 ("selftests: net: increase the delay for relative
> cmsg_time.sh test") widened the accepted value range 8x but we still
> see flakes (at a rate of around 7%).

you have undid the 8x change by this commit (without mentioning that)
[fine for me]

> 
> Return XFAIL for the most timing sensitive test on slow machines.

code change looks fine for me, and does exactly that, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> 
> Before:
> 
>    # ./cmsg_time.sh
>      Case UDPv4  - TXTIME rel returned '8074us - 7397us < 4000', expected 'OK'
>    FAIL - 1/36 cases failed
> 
> After:
> 
>    # ./cmsg_time.sh
>      Case UDPv4  - TXTIME rel returned '1123us - 941us < 500', expected 'OK' (XFAIL)
>      Case UDPv6  - TXTIME rel returned '1227us - 776us < 500', expected 'OK' (XFAIL)
>    OK
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>