netdev - Re: [PATCH net] netdev: avoid CFI problems with sock priv helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc0541ea-00e6-4444-ae90-a6cbeec3f6d9@redhat.com>
Date: Thu, 16 Jan 2025 13:20:11 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, Li Li <dualli@...omium.org>, donald.hunter@...il.com,
 sdf@...ichev.me, almasrymina@...gle.com
Subject: Re: [PATCH net] netdev: avoid CFI problems with sock priv helpers



On 1/15/25 5:14 PM, Jakub Kicinski wrote:
> Li Li reports that casting away callback type may cause issues
> for CFI. Let's generate a small wrapper for each callback,
> to make sure compiler sees the anticipated types.
> 
> Reported-by: Li Li <dualli@...omium.org>
> Link: https://lore.kernel.org/CANBPYPjQVqmzZ4J=rVQX87a9iuwmaetULwbK_5_3YWk2eGzkaA@mail.gmail.com
> Fixes: 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: sdf@...ichev.me
> CC: almasrymina@...gle.com

FTR, I took the liberty of applying this patch before the 24H grace
period to fit todays net PR and avoid shipping a 6.13 final with a known
serious issue.

/P