netdev - Re: [PATCH net-next] selftests/net: packetdrill: make tcp buf limited timing tests benign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <678904353ca7e_3710bc294ef@willemb.c.googlers.com.notmuch>
Date: Thu, 16 Jan 2025 08:05:57 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 Jakub Kicinski <kuba@...nel.org>, 
 shuah@...nel.org, 
 willemb@...gle.com, 
 matttbe@...nel.org, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests/net: packetdrill: make tcp buf limited
 timing tests benign

Jakub Kicinski wrote:
> The following tests are failing on debug kernels:
> 
>   tcp_tcp_info_tcp-info-rwnd-limited.pkt
>   tcp_tcp_info_tcp-info-sndbuf-limited.pkt
> 
> with reports like:
> 
>       assert 19000 <= tcpi_sndbuf_limited <= 21000, tcpi_sndbuf_limited; \
>   AssertionError: 18000
> 
> and:
> 
>       assert 348000 <= tcpi_busy_time <= 360000, tcpi_busy_time
>   AssertionError: 362000
> 
> Extend commit 912d6f669725 ("selftests/net: packetdrill: report benign
> debug flakes as xfail") to cover them.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks.

I see that we'll still have a few flakes on dbg. Perhaps one total
failure a day. From the following.

tcp-close-close-local-close-then-remote-fin-pkt
tcp-ecn-ecn-uses-ect0-pkt
tcp-eor-no-coalesce-retrans-pkt
tcp-slow-start-slow-start-after-win-update-pkt
tcp-sack-sack-route-refresh-ip-tos-pkt
tcp-ts-recent-reset-tsval-pkt
tcp-zerocopy-closed-pkt

We'll take a look after this change whether we can make these
more resilient. But likely also allow-list or even xfail for
everything in dbg.