netdev - Re: [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97dffc47-3363-4a0d-983a-5620fa5ad745@intel.com>
Date: Thu, 16 Jan 2025 17:19:43 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	<jacob.e.keller@...el.com>, <xudu@...hat.com>
CC: <netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com>,
	<magnus.karlsson@...el.com>, <mschmidt@...hat.com>, <jmaxwell@...hat.com>,
	<poros@...hat.com>, <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU
 traffic

On 1/16/25 16:39, Maciej Fijalkowski wrote:
> Hello in 2025,
> 
> this patchset fixes a pretty nasty issue that was reported by RedHat
> folks which occured after ~30 minutes (this value varied, just trying
> here to state that it was not observed immediately but rather after a
> considerable longer amount of time) when ice driver was tortured with
> jumbo frames via mix of iperf traffic executed simultaneously with
> wrk/nginx on client/server sides (HTTP and TCP workloads basically).
> 


> 
> Special thanks to Xu Du for providing reproducer and Jacob Keller for
> initial extensive analysis.
> 
> Thanks,
> Maciej

Thank you all for this piece of gold, including description.

> 
> Maciej Fijalkowski (3):
>    ice: put Rx buffers after being done with current frame
>    ice: gather page_count()'s of each frag right before XDP prog call
>    ice: stop storing XDP verdict within ice_rx_buf
> 
>   drivers/net/ethernet/intel/ice/ice_txrx.c     | 128 +++++++++++-------
>   drivers/net/ethernet/intel/ice/ice_txrx.h     |   1 -
>   drivers/net/ethernet/intel/ice/ice_txrx_lib.h |  43 ------
>   3 files changed, 82 insertions(+), 90 deletions(-)
> 

It was a pleasure to read this series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>