netdev - Re: [PATCH net 1/1 v3] net: sched: Disallow replacing of child qdisc from one parent to another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250115173335.0f142a28@kernel.org>
Date: Wed, 15 Jan 2025 17:33:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: netdev@...r.kernel.org, jiri@...nulli.us, xiyou.wangcong@...il.com,
 davem@...emloft.net, edumazet@...gle.com, security@...nel.org,
 nnamrec@...il.com
Subject: Re: [PATCH net 1/1 v3] net: sched: Disallow replacing of child
 qdisc from one parent to another

On Wed, 15 Jan 2025 15:39:43 -0500 Jamal Hadi Salim wrote:
> > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> > index 300430b8c4d2..fac9c946a4c7 100644
> > --- a/net/sched/sch_api.c
> > +++ b/net/sched/sch_api.c
> > @@ -1664,6 +1664,10 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
> >                                 q = qdisc_lookup(dev, tcm->tcm_handle);
> >                                 if (!q)
> >                                         goto create_n_graft;
> > +                               if (q->parent != tcm->tcm_parent) {
> > +                                       NL_SET_ERR_MSG(extack, "Cannot move an existing qdisc to a different parent");
> > +                                       return -EINVAL;
> > +                               }  
> 
> Yes, this should work as well - doesnt have to save the leaf_q, so more optimal.
> Please send the patch.

I'm gonna keep your commit and just post a v4, hope that's okay.