netdev - Re: [PATCH RFC net-next] net: phylink: always do a major config when attaching a SFP PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f20c9744-3953-40e7-a9c9-5534b25d2e2a@gmail.com>
Date: Thu, 16 Jan 2025 19:46:51 +0100
From: Eric Woudstra <ericwouds@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next] net: phylink: always do a major config when
 attaching a SFP PHY



On 1/16/25 12:19 AM, Russell King (Oracle) wrote:
> Hi Eric,
> 
> I'd like to get a tested-by from you before sending this for merging,
> as this should fix your reported issue.

Tested-by: Eric Woudstra <ericwouds@...il.com>

It works ok, thanks.

The kernel log shows:

[root@...r3 ~]# dmesg | grep eth1
[    2.515546] mtk_soc_eth 15100000.ethernet eth1: mediatek frame engine at 0xffff800082300000, irq 123
[   41.406446] mtk_soc_eth 15100000.ethernet eth1: configuring for inband/2500base-x link mode
[   41.414819] mtk_soc_eth 15100000.ethernet eth1: major config, requested inband/2500base-x
[   41.422983] mtk_soc_eth 15100000.ethernet eth1: interface 2500base-x inband modes: pcs=01 phy=00
[   41.431936] mtk_soc_eth 15100000.ethernet eth1: major config, active inband/inband,an-disabled/2500base-x
[   41.441523] mtk_soc_eth 15100000.ethernet eth1: phylink_mac_config: mode=inband/2500base-x/none adv=00,00000000,00008000,0000e240 pause=04
[   42.370423] mtk_soc_eth 15100000.ethernet eth1:  interface 2 (mii) rate match none supports 0-3,6-7,13-14
[   42.380034] mtk_soc_eth 15100000.ethernet eth1:  interface 3 (gmii) rate match none supports 0-3,5-7,13-14
[   42.389698] mtk_soc_eth 15100000.ethernet eth1:  interface 4 (sgmii) rate match none supports 0-3,5-7,13-14
[   42.399441] mtk_soc_eth 15100000.ethernet eth1:  interface 22 (1000base-x) rate match none supports 5-7,13-14
[   42.409348] mtk_soc_eth 15100000.ethernet eth1:  interface 23 (2500base-x) rate match none supports 6-7,13-14,47
[   42.744938] mtk_soc_eth 15100000.ethernet eth1: PHY i2c:sfp-1:11 uses interfaces 4,23, validating 4,23
[   42.754256] mtk_soc_eth 15100000.ethernet eth1:  interface 4 (sgmii) rate match none supports 0-3,5-7,13-14
[   42.800352] mtk_soc_eth 15100000.ethernet eth1:  interface 23 (2500base-x) rate match none supports 6-7,13-14,47
[   42.810541] mtk_soc_eth 15100000.ethernet eth1: PHY [i2c:sfp-1:11] driver [RTL8221B-VB-CG 2.5Gbps PHY (C45)] (irq=POLL)
[   42.821312] mtk_soc_eth 15100000.ethernet eth1: phy: 2500base-x setting supported 00,00000000,00008000,000060ef advertising 00,00000000,00008000,000060ef
[   42.835035] mtk_soc_eth 15100000.ethernet eth1: requesting link mode inband/2500base-x with support 00,00000000,00008000,000060ef
[   42.846675] mtk_soc_eth 15100000.ethernet eth1: major config, requested inband/2500base-x
[   42.854847] mtk_soc_eth 15100000.ethernet eth1: interface 2500base-x inband modes: pcs=01 phy=00
[   42.863616] mtk_soc_eth 15100000.ethernet eth1: major config, active phy/outband/2500base-x
[   42.871966] mtk_soc_eth 15100000.ethernet eth1: phylink_mac_config: mode=phy/2500base-x/none adv=00,00000000,00008000,000060ef pause=04
[   43.590342] mtk_soc_eth 15100000.ethernet eth1: phy link down 2500base-x/Unknown/Unknown/none/off
[   43.607350] brlan: port 5(eth1) entered blocking state
[   43.612481] brlan: port 5(eth1) entered disabled state
[   43.617707] mtk_soc_eth 15100000.ethernet eth1: entered allmulticast mode
[   43.624679] mtk_soc_eth 15100000.ethernet eth1: entered promiscuous mode
[   47.700338] mtk_soc_eth 15100000.ethernet eth1: phy link up 2500base-x/2.5Gbps/Full/none/rx/tx
[   47.700357] mtk_soc_eth 15100000.ethernet eth1: Link is Up - 2.5Gbps/Full - flow control rx/tx
[   47.717579] mtk_soc_eth 15100000.ethernet eth1: No phy led trigger registered for speed(2500)
[   47.734637] brlan: port 5(eth1) entered blocking state
[   47.739782] brlan: port 5(eth1) entered forwarding state