netdev - Re: [PATCH net-next v10 05/22] net: page pool: export page_pool_set_dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f65232e3-9bef-444c-8e17-2e31b2dcfe05@gmail.com>
Date: Thu, 16 Jan 2025 02:12:33 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, David Wei <dw@...idwei.uk>
Cc: io-uring@...r.kernel.org, netdev@...r.kernel.org,
 Jens Axboe <axboe@...nel.dk>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, David Ahern <dsahern@...nel.org>,
 Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v10 05/22] net: page pool: export
 page_pool_set_dma_addr_netmem()

On 1/16/25 00:39, Jakub Kicinski wrote:
> On Wed, 15 Jan 2025 16:35:21 -0800 Jakub Kicinski wrote:
>> On Wed,  8 Jan 2025 14:06:26 -0800 David Wei wrote:
>>> Export page_pool_set_dma_addr_netmem() in page_pool/helpers.h. This is
>>> needed by memory provider implementations that are outside of net/ to be
>>> able to set the dma addrs on net_iovs during alloc/free.
>>
>> Please keep helpers.h focused on the driver-facing API.
>> Maybe create a new header page_pool/private.h would be
>> sufficiently suggestive.
> 
> Or you can put it in the memory_provider one from the next patch.

ok

-- 
Pavel Begunkov